Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExceptionInfo.from_current: pass through exprinfo #6002

Merged
merged 1 commit into from
Oct 19, 2019
Merged

ExceptionInfo.from_current: pass through exprinfo #6002

merged 1 commit into from
Oct 19, 2019

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Oct 19, 2019

This was lost in 11f1f79.

@blueyed blueyed requested a review from bluetech October 19, 2019 01:03
@RonnyPfannschmidt
Copy link
Member

Good find, got a idea for a test?

bluetech
bluetech approved these changes Oct 19, 2019
View reviewed changes
Copy link
Member

@bluetech bluetech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this.

@blueyed
Copy link
Contributor Author

blueyed commented Oct 19, 2019

@RonnyPfannschmidt
Not from the top of my head - do you have one?

@blueyed
Copy link
Contributor Author

blueyed commented Oct 19, 2019

I do not fully grasp the API there btw, I think something more explicit like #6003 makes sense here.

@blueyed blueyed merged commit 119bf66 into pytest-dev:features Oct 19, 2019
@blueyed blueyed deleted the exprinfo-arg branch October 19, 2019 17:20
@RonnyPfannschmidt
Copy link
Member

@blueyed should we add a follow-up task to make a test for this one, i have no idea myself off hand

@blueyed
Copy link
Contributor Author

blueyed commented Oct 19, 2019 •
edited
Loading

@RonnyPfannschmidt not really necessary AFAICS.
But feedback on #6003 / the idea from there would be good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluetech bluetech bluetech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blueyed @RonnyPfannschmidt @bluetech